Re: Review request for JDK-8131751: Test javax/swing/plaf/gtk/crash/RenderBadPictureCrash.java fails UnsupportedOperationException

[Semyon Sadetsky]

Looks good.

--Semyon

On 2/1/2016 3:32 PM, Vikrant Agarwal wrote:

Thanks Alexander, I have updated the webrev for the same.

Updated Webrev: http://cr.openjdk.java.net/~ntv/vikrant/8131751/webrev.01/ <http://cr.openjdk.java.net/%7Entv/vikrant/8131751/webrev.01/>

*Bug:* https://bugs.openjdk.java.net/browse/JDK-8131751

Best Regards,

Vikrant

*From:*Alexander Scherbatiy
*Sent:* Thursday, January 28, 2016 11:13 PM
*To:* Vikrant Agarwal; swing-dev@openjdk.java.net

*Subject:* Re: <Swing Dev> Review request for JDK-8131751: Test javax/swing/plaf/gtk/crash/RenderBadPictureCrash.java fails UnsupportedOperationException

The fix looks good to me.

Just a small note: it could be better to get the graphics device from the frame itself (f.getGraphicsConfiguration().getDevice()).

Thanks,
Alexandr.

On 1/28/2016 2:32 AM, Vikrant Agarwal wrote:

    Hi All,

    Kindly review the fix for JDK9.

    *Bug:* https://bugs.openjdk.java.net/browse/JDK-8131751

    *Webrev:* http://cr.openjdk.java.net/~srastogi/8131751/webrev.00/
    <http://cr.openjdk.java.net/%7Esrastogi/8131751/webrev.00/>

    *Issue:* [TEST_BUG] Test
    javax/swing/plaf/gtk/crash/RenderBadPictureCrash.java fails
    UnsupportedOperationException

    *Cause:* test failed on those systems where PERPIXEL_TRANSLUCENT
    translucency is not supported as it is doing  f.setBackground(new
    Color(0, 0, 0, 0)); (making alpha value 0)

    *Fix:* Added a check for checking support for PERPIXEL_TRANSLUCENT
    translucency before f.setBackground(new Color(0, 0, 0, 0));

    Best Regards,

    Vikrant Agarwal