The fix looks good to me.
Thanks,
Alexandr.
On 3/29/2016 8:29 AM, Semyon Sadetsky wrote:
On 3/29/2016 6:16 PM, Alexander Scherbatiy wrote:
Should white spaces be removed within parentheses?
I think it is better to preserve the format user specified.
Spaces are a valid symbols in CSS, they improve readability.
--Semyon
Thanks,
Alexandr.
On 14/03/16 19:13, Semyon Sadetsky wrote:
Thanks, Sergey. The webrev is corrected.
On 3/14/2016 4:22 PM, Sergey Bylokhov wrote:
Something strange occurs in the webrev for the testcase, there is
no diff.
On 14.03.16 14:29, Semyon Sadetsky wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8149631
webrev: http://cr.openjdk.java.net/~ssadetsky/8149631/webrev.00/
The issue is a regression of 4419748 which added support for border
sides but it parse the rgb(...) color values wrong. Also before
4419748
the parenthesis notations worked only for CSS attribute that is not
expected to contain several values. The reason is splitting the
multi-value CSS attribute (for example, "background: rgb(0, 0, 0)
url(
'b.gif' ) no-repeat;") using space divider didn't take into
account that
spaces within parenthesis should not be used as top-level dividers.
Fixing the value splitting should correct the situation for (...)
entries in all multi-value CSS attributes.
--Semyon
