Hi,

You are deprecating shouldYieldFocus(JComponent) and yet this class directly uses it.
Is this deprecation really the right thing to do ?

The new over-loaded shouldYieldFocus() is perhaps not much more than a utility.
And the doc says "calls verify(input)" which seems odd since you do not
directly call it. And you are just describing what the default implementation
does aren't you ?

-phil.

On 04/19/2016 04:40 AM, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8154431
webrev: http://cr.openjdk.java.net/~ssadetsky/8154431/webrev.00/

The thing is the Swing validation doesn't allow to validate state of the target component of input focus transfer operation. To support that the fix adds two new methods verifyTarget(JComponent target) and shouldYieldFocus(JComponent source, JComponent target) to the javax.swing.InputVerifier class, and its old shouldYieldFocus(JComponent input) is marked as deprecated.
The solution guaranties full compatibility with previous JDK versions.

--Semyon


Reply via email to