On 24/05/16 15:22, Avik Niyogi wrote:
Hi All,
Kindly review the fix for JDK9.
*Bug*: https://bugs.openjdk.java.net/browse/JDK-8144161
<https://bugs.openjdk.java.net/browse/JDK-7124218>
*Webrev*:http://cr.openjdk.java.net/~aniyogi/8144161/webrev.00/
<http://cr.openjdk.java.net/%7Eaniyogi/8144161/webrev.00/>
*Issue*: Test case throws an exception when the behaviour is as expected.
*Cause*: The expected behaviour for comboBox was not accounted for
Aqua look and feel in test case.
*Fix*: The test case was fixed to account for the Aqua LAF behaviour
for comboBox dropdown menu which extends beyond the screen Insets (the
dock height) for Mac.
- the bug link points to the bug 7124218 instead of 8144161
- The exception should be re-thrown on the line 63
- Some code formatting change is not clear (see for example line 24
or 133)
Thanks,
Alexandr.
With Regards,
Avik Niyogi