The fix should be prepared for the JDK 9 first and only after that be
backported to JDK 8u.
Could you apply the fix to JDK 9 client repository
http://hg.openjdk.java.net/jdk9/client
and send the webrev of the fix plus the test (see
http://openjdk.java.net/guide/webrevHelp.html).
The fix shouldn't contain comments with the old code lines. I believe
that references to the bug number are also unnecessary for this case.
You mentioned that there are artifacts with a table displaying in JDK
9. Do they appear only after fix of they also present even without the fix?
Thanks,
Alexandr.
On 5/27/2016 9:23 AM, Abossolo Foh Guy wrote:
Hello,
Please, please ... could someone examine the patch for JDK-8133864
that I suggested ? I really need it to implement matrix display in my
application. I've spent long time in 2012 to find what was wrong in
tableview. I know Victor's comment was not good but you could compare
with the tableview implementation in the swing/text/html package which
works fine.
Beware, the display (with java 9 119) for I18nLayoutTest.java is not
the same with i18n true (bad) or i18n false (good). With i18n true the
table go down.
Best regards.
----------------------------------------------------------------------------------------------------------------------
Hello,
I built the recent OpenJDK8u and OpenJDK9 sources
(openjdk_versions.txt) with the patch shown in the output_diff.txt
attachment.
I applied your patch for JDK-8133864 : Wrong display, when the
document I18n properties is true.
And I applied my patch for JDK-7169915 : Swing Table Layout bad
repaint of the row.
All works fine in OpenJDK8u and the document is well displayed. The
table appears as I expected with all its lines and columns
(JDK-8133864 solved), size and borders included even if we write some
text inside (JDK-7169915 solved). I can modify it as I want.
But with OpenJDK9, the display of the document is wrong. The table
appears as I expected with all its lines and columns (JDK-8133864
solved), size and borders included (JDK-7169915 solved) but the entire
document display is modified, the table is displayed on a new line.
And the document became unuseable, I can't modify it as I want.
This morning, I ran the same test programme (CodeBug.java in
attachment) with the Oracle JDK9 b114 (i.e. OpenJDK9 only with your
patch for JDK-8133864) : The table appears as I expected with all its
lines and columns (JDK-8133864 solved) but the size and borders are
bad repainted when we write some text inside (JDK-7169915 solved). And
the document became unuseable too, I can't modify it as I want.
My conclusion :
1- JDK-8133864 is solved with your PATCH.
2- JDK-7169915 could be solved with my PATCH.
3- There is regression between JDK8 and JDK9 may be in the Views
arrangement.
Best regards.
----------------------------------------------------------------------------------------------------------------------
Hello,
Could you apply the modification I suggested 4 years ago about the Bug
: JDK-7169915 : Swing Table Layout bad repaint of the row.
The test case I had sent in 2012 is the same I used in : JDK-8133864
Wrong display, when the document I18n properties is true.
A version of this test (called I18nLayoutTest.java) is now candidate
as part of tests for JDK 9 (/test/javax/swing/text/TableView/)
Yours faithfully.
