Hi Pete, That’s a problem, yes. Though, even without that action functionality, JList becomes navigate-able with VO (am I right?) that is quite the difference to what it is now. So, if you don’t find any way to make it into jdk8, a partial fix would also be valuable.
Thanks, Anton. > On 24 Jun 2016, at 00:12, Pete Brunet <peter.bru...@oracle.com> wrote: > > Hi Anton, The way it is I can't backport it because I changed the class > signature of > https://docs.oracle.com/javase/8/docs/api/javax/swing/JList.AccessibleJList.AccessibleJListChild.html > > <https://docs.oracle.com/javase/8/docs/api/javax/swing/JList.AccessibleJList.AccessibleJListChild.html> > by adding "implements AccessibleAction" and this will cause a JCK failure. > > Next week I'll see if there is any way I can come up with a different > solution that will allow me to backport it. > > Pete > > On 6/23/16 12:21 PM, Anton Tarasov wrote: >> Hi Pete, >> >>> On 22 Jun 2016, at 17:41, Pete Brunet < >>> <mailto:peter.bru...@oracle.com>peter.bru...@oracle.com >>> <mailto:peter.bru...@oracle.com>> wrote: >>> >>> Thanks Anton, I fixed the first two issues. For the last one did you try >>> VO+Shift+downarrow first to interact with the list? >> >> Now I did try it and it worked fine, thanks for letting me know. >> >> Please, share your thoughts on backporting your OSX a11y fixes into jdk8. As >> the a11y codebase is quite the same, this seems possible with reasonable >> time investment. >> >> Thank you for the long-awaited fix! ) >> >> Anton. >> >>> >>> Pete >>> >>> On 6/22/16 4:28 AM, Anton Tarasov wrote: >>>> Hi Pete, >>>> >>>> I went through the fix and found it looking fine to me, except for these >>>> two minor issues: >>>> >>>> - JavaComponentAccessibility.m >>>> >>>> In this chunk: >>>> >>>> +- (void)postSelectionChanged >>>> +{ >>>> + NSAccessibilityPostNotification(self, >>>> NSAccessibilitySelectedChildrenChangedNotification); >>>> +} >>>> >>>> AWT_ASSERT_APPKIT_THREAD is missing. >>>> >>>> - CAccessibility.java >>>> >>>> A typo in the comment: "will will annouce” >>>> >>>> Also, I gave it a try with jdk8u-dev, locally, along with the following >>>> pre-applied: >>>> >>>> 8076554: [macosx] Custom Swing text components need to allow standard >>>> accessibility >>>> >>>> JList is spoken fine by VO, though I wasn’t able to make the following: >>>> >>>> >>>>> On 18 Jun 2016, at 05:31, Pete Brunet <peter.bru...@oracle.com >>>>> <mailto:peter.bru...@oracle.com>> wrote: >>>>> >>>>> Please review the following patch. >>>>> >>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8145207 >>>>> <https://bugs.openjdk.java.net/browse/JDK-8145207> >>>>> Patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8145207/webrev.00/ >>>>> <http://cr.openjdk.java.net/%7Eptbrunet/JDK-8145207/webrev.00/> >>>>> >>>>> This fixes the following functionality that was not working with the >>>>> JList of ListDemo of SwingSet2. >>>>> - start VoiceOver >>>>> - start SwingSet2 >>>>> - start the ListDemo >>>>> - press Tab until focus is on the list, should hear VO when changing >>>>> selections with up/down arrow >>>>> - when interacting with list should hear that there are 30 (total) >>>>> items, not 26 (visible) items >>>>> - when using control+option+up/downarrow should be able to move to and >>>>> select (control+option+spacebar) non-visible items past the 26th visible >>>>> item >>>> >>>> VO+up/down just moves up/down the sibling panels (conforming >>>> <https://www.apple.com/voiceover/info/guide/_1131.html>https://www.apple.com/voiceover/info/guide/_1131.html >>>> <https://www.apple.com/voiceover/info/guide/_1131.html>) but not the list >>>> items. >>>> Could you please shed a light on it? >>>> >>>> Thanks, >>>> Anton. >>>> >>>> P.S. >>>> Will it be possible to back-port it to 8u-dev? >>>> >>>> >>>>> - should be able to multi-select both visible and invisible items using >>>>> control+option+command+return and VO should read the item just added >>>>> - should be able to shift extend items with shift up or shift down arrow >>>>> and VO should announce the item just added or removed >>>>> >>>>> Pete >>>>> >>>>> >>>> >>> >> >
