Hello,

Could you review the updated fix:
  http://cr.openjdk.java.net/~alexsch/8165594/webrev.02

 The code formatting issues are updated.

On 9/14/2016 8:02 PM, Semyon Sadetsky wrote:
Hi Alexander,

When I press the arrow button (for example in the "111" combo) several times I can see artifacts. They are well seen in scale x4.
I have filled an issue on it: JDK-8166368 JComboBox drawing has artifacts with Windows Classic L&F on HiDPI display
    https://bugs.openjdk.java.net/browse/JDK-8166368

  Thanks,
  Alexandr.


--Semyon


On 9/14/2016 5:39 PM, Alexandr Scherbatiy wrote:

Hello,

Could you review the updated fix:
  http://cr.openjdk.java.net/~alexsch/8165594/webrev.01

 - HiDPI icons are only drawn for scaled graphics.

The screenshots [1], [2], and [3] show difference between icons drawing before and after the fix for scales 1x, 2x, and 4x.

[1] http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-1x_01.png [2] http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x_01.png [3] http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x_01.png

  Thanks,
  Alexandr.

On 9/8/2016 10:59 AM, Andrej Golovnin wrote:
Hi Alexandr,

   [1]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-1x.png
The icons do not look right to me. Take look at the top-left part of
the radio button. There is a white pixel between the shadow lines. And
in the selected state there should be a black circle. But instead it
is a square. The check sign of the checkbox is too thin. And the
arrows of the combobox and the vertical scroll bar should have a
single pixel at the top/bottom side. But now they have two pixels.

It would be also nice to see a screen shot of the native Windows
components for comparison.

Personally when I would make changes like that, then my code would
look like this:

if (isNotHiDPI() || itMakesMoreSenseToUseTheOldCode()) {
    // use the old good code.
} else {
    // use the new code
}

Best regards,
Andrej Golovnin

   [2]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x.png
   [3]
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x.png

  Thanks,
  Alexandr.





Reply via email to