On 04.10.16 15:46, Semyon Sadetsky wrote:
It is the similar, but the paintButtonBackground has no an assertion
and simply returns if the titlePaneParent is not a JInternalFrame or
JInternalFrame.JDesktopIcon, which means that you cannot simply cast
the parent of the component to the JInternalFrame in the
updateFrameGeometry.

But paintFrameBorder for example has an assertion. I think it will be
good to cleanup this methods a little bit. At lest this sequence of
similar instanceof inside and outside updateFrameGeometry is strange.
The webrev is updated:
http://cr.openjdk.java.net/~ssadetsky/8062525/webrev.01/

Looks fine.



On 9/21/2015 2:33 PM, Semyon Sadetsky wrote:

Hello,

Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8062525
webrev: http://cr.openjdk.java.net/~ssadetsky/8062525/webrev.00/

In the type check of the updateFrameGeometry() method the internal
frame
title buttons was not taken into account.

--Semyon










--
Best regards, Sergey.

Reply via email to