The fix covers the parentComponent=null case.
What about the second case when non-null component is provided but it
has no frame?
--Semyon
On 05/12/2017 12:51 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a spec violation issue whereby if in
JOptionPane.showInternalConfirmDialog(Component parentComponent,
Object message)
"parentComponent" is null, we are getting RuntimeException
"parentComponent does not have a valid parent"
but as per spec,
https://docs.oracle.com/javase/8/docs/api/index.html?javax/swing/JOptionPane.html
it says "|parentComponent| - determines the |Frame| in which the
dialog is displayed; if |null|, or if the |parentComponent| has no
|Frame|, a default |Frame| is used"
This violation exists for all overridden showInternalConfirmDialog
methods and showInternalOptionDialog.
The proposed fix creates a default JFrame and shows the confirm dialog
in it, as stated in the spec.
Bug: https://bugs.openjdk.java.net/browse/JDK-7042497
webrev: http://cr.openjdk.java.net/~psadhukhan/7042497/webrev.00/
Regards
Prasanta
