Hi, Prasanta. I have few small notes. - Did you check why the null value was passed to this method? - It seems that the tests are passed by default. It would be good to run them over the installed l&f. In this case they will fail before the fix. - Is it possible to remove the html files from the tests? - The tests also have some common issues, the Swing components are accessed on non-edt thread. some unnecessary commented code, etc.
----- prasanta.sadhuk...@oracle.com wrote: > Hi All, Please review a subitem fix of JDK-7190554 where some closed regression test is failing with Nimbus L&F. Issue was we were getting NPE > which is because a null style was used in SynthPanelUI to generate the > SynthContext > > java.lang.NullPointerException: You must supply a non-null component, region > and style > at > java.desktop/javax.swing.plaf.synth.SynthContext.getContext(SynthContext.java:58) > > at > java.desktop/javax.swing.plaf.synth.SynthContext.getContext(SynthContext.java:49) > > at > java.desktop/javax.swing.plaf.synth.SynthPanelUI.getContext(SynthPanelUI.java:128) > > at > java.desktop/javax.swing.plaf.synth.SynthPanelUI.updateStyle(SynthPanelUI.java:115) > > at > java.desktop/javax.swing.plaf.synth.SynthPanelUI.installDefaults(SynthPanelUI.java:100) > > > Proposed fix is to generate a style before generating SynthContext because as > per spec, > https://docs.oracle.com/javase/8/docs/api/index.html?javax/swing/plaf/synth/SynthContext.html > > it should throw NPE - if component, region or style is null. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8181421 > webrev: http://cr.openjdk.java.net/~psadhukhan/8181421/webrev.00/ > > Regards > Prasanta >
