Hi Srinivas,
Here are few review comments :
1. Add this bug id to the @bug jtreg tag in test
2. Replace generic import statements with specific ones
3. You are calling - b.doTest(); - in a try catch block. This will catch any
exception and print stack trace.
I think we can remove this try-catch block - simply make a call to
b.doTest(), if an exception is thrown, it is thrown out from main() and jtreg
framework will catch it and mark the test as failed.
4. Line 63 in your file has a throw error - this can be converted to
exception.
5. Keep four spaces indentation level
Regards,
Ajit
From: Srinivas Mandalika
Sent: Monday, June 12, 2017 1:51 PM
To: [email protected]
Subject: <Swing Dev> [9][TESTBUG]: Review Request for JDK-8169958 :
javax/swing/JSpinner/5012888: Spinner value should be more than 1
Hi All,
Please review the test bug fix for JDK-8169958 : javax/swing/JSpinner/5012888:
Spinner value should be more than 1.
Issue:
In this bug, click & hold on arrow of JSpinner only transfers focus and does
not change spinner value. This behavior is intermittently seen in the automated
test but is working as expected when checked for manualy. The test was failing
robot clicks out of sync with the yet to be maximized frame.
Fix:
Ensure the robot waits for the frame to be maximized before the clicks on the
Spinner. Also ensure the main application frame is maximized explicitly.
Testing:
Tested the potential fix on winx64, linux with JDK8, 9 several times with
running tests individually clubbed with the previous test and the entire suite
(i.e javax/swing) put to ensure that the issue is not repeated.
Bug Id:
https://bugs.openjdk.java.net/browse/JDK-8169958
WebRev Request:
http://cr.openjdk.java.net/~akolarkunnu/8169958/webrev.00/
Regards,
Srinivas M
