The change is fine. If you can't find a way to easily write a regression
test
(not sure this bug merits a lot of effort in that direction), then mark the
bug with an appropriate label.
-phil.
On 6/12/17, 3:54 AM, Shashidhara Veerabhadraiah wrote:
Hi All,
Please review the code bug fix for JDK-6267105:UIDefaults.getUIError
dumps error message to System.err and also throws Error.
Issue:
Error message was getting dumped to the system.err even though the
recovery actions were performed leading to unnecessary confusion regarding the
actual behavior.
Fix:
This fix removes the call which prints the message to the system.err and
stores the message in the Error class. This same message can be retrieved after
we catch the error and calling getMessage() of the Error class. Through
catching the error, the user can perform necessary recovery actions without
cluttering the system.err. This fix does not modifies the 'user effect' as the
user would still get the same error as they were getting before this fix.
Test:
Now the system.err does not get cluttered though we performed the
necessary recovery actions. The error message string can be recovered by
calling getMessage() if needed.
Bug:
https://bugs.openjdk.java.net/browse/JDK-6267105
Webrev:
http://cr.openjdk.java.net/~aghaisas/shashi/6267105/webrev_00/
Thanks and regards,
Shashi
