looks good to me.
Regards
Prasanta
On 7/13/2017 3:20 PM, Vikrant Agarwal wrote:
Hi All,
Please review the following:
Bug : JDK-8184272 <https://bugs.openjdk.java.net/browse/JDK-8184272>
JDK 10 Webrev: http://cr.openjdk.java.net/~vagarwal/8184272/webrev.00/
<http://cr.openjdk.java.net/%7Evagarwal/8184272/webrev.00/>
Summary:
Jemmy JFileChooserOperator.enterSubDir does not navigate to sub
directory and instead goes to user's default directory
The present code for JFileChooserOperator.enterSubDir(..) first
selects the directory, then tries to navigate to the selected
directory by getting the path of selected directory from
getSelectedFile().
JFileChooserOperator.getSelectedFile() calls
JFileChooser.getSelectedFile(), which returns the path for the
selected file, but if the selection is a directory, then it returns
Null if the fileSelectionMode is not set to select directory.
This when passed to setCurrentDirectory() sets the diectory as user's
default directory.
Doing setFileSelectionMode(JFileChooser.FILES_AND_DIRECTORIES) ensures
that the getSelectedFile() returns the correct path even in case it is
a directory.
Best Regards,
Vikrant