Re: [10] JDK-8058785: Nimbus disabled tooltip needs border

Sergey Bylokhov Mon, 31 Jul 2017 13:39:21 -0700

Small comments about the test.
 - Is the "Thread T1" is necessary, looks like all should work w/o it.
 - Please never use empty catch blocks, but rethrow an exception:
  59                 try {
  60                     test.createUI();
  61                 } catch (Exception e) {
  62
  63                 }


On 31.07.2017 5:10, Shashidhara Veerabhadraiah wrote:

Hi Prem, Please find the new Webrev:

_http://cr.openjdk.java.net/~pkbalakr/shashi/8058785/webrev.01/_

I have tested thisfixwith teston windows,linuxand mac os.And in all ofthem it is passing.


Thanks and regards,

Shashi

-----Original Message-----

From: Prem Balakrishnan

Sent: Monday, July 31, 2017 2:26 PM

To: Shashidhara Veerabhadraiah <shashidhara.veerabhadra...@oracle.com>

Cc: swing-dev@openjdk.java.net; Sergey Bylokhov <sergey.bylok...@oracle.com>

Subject: RE: <Swing Dev> [10] JDK-8058785: Nimbus disabled tooltip needsborder


Hi Shashi,

Fix looks good to me.

Can you add a regression test?

Regards,

Prem

-----Original Message-----

From: Sergey Bylokhov

Sent: Saturday, July 29, 2017 4:44 AM

To: Shashidhara Veerabhadraiah

Cc: swing-dev@openjdk.java.net

Subject: Re: <Swing Dev> [10] JDK-8058785: Nimbus disabled tooltip needsborder


+1, looks fine.

On 28.07.2017 0:13, Shashidhara Veerabhadraiah wrote:

Hi Sergey, It is a “nimbusBorder” property set to [*red="146"

green="151" blue="161" alpha="255"*] and is same as menubar border.

There are many items being using the nimbusBorder property and they are all 
have the same the RGBA values.

But JLabel  ‘disabled’has a different value of:

<matte red="116" green="121" blue="128" alpha="255"

uiDefaultParentName="nimbusBorder" hueOffset="-0.013888836"

saturationOffset="5.823001E-4" brightnessOffset="-0.12941176"

alphaOffset="0"/>

But the above value is same as the  ‘enabled’border as well including size.

Typically, the border size and color of the  ‘disabled’item are

maintained same as the  ‘enabled’state.

Thanks and regards,

Shashi

*From:* Sergey Bylokhov

*Sent:* Thursday, July 27, 2017 9:53 PM

*To:* Shashidhara Veerabhadraiah

<shashidhara.veerabhadra...@oracle.com>

*Cc:* swing-dev@openjdk.java.net

*Subject:* Re: <Swing Dev> [10] JDK-8058785: Nimbus disabled tooltip

needs border

Hi, Shashi.

I assume that other components like menu items have the same border,

right?(size and color).

----- shashidhara.veerabhadra...@oracle.com

<mailto:shashidhara.veerabhadra...@oracle.com> wrote:

Hi All, Please review a fix for the JDK-8058785 where the disabled

tooltip does not draws the border and blends into the disabled button

and looks bad. Below is the picture of current JDK output /_without_/

the fix.

_Solution and fix:_I have updated the skin.laf file to draw a border

for the disabled tool tip indicator. Below is the pic after the fix.

Update to skin.laf XML file would auto generate these files(along with

other files):

./build/windows-x86_64-normal-server-fastdebug/support/gensrc/java.des

ktop/javax/swing/plaf/nimbus/NimbusDefaults.java

./build/windows-x86_64-normal-server-fastdebug/support/gensrc/java.desktop/javax/swing/plaf/nimbus/ToolTipPainter.java.

Bug: https://bugs.openjdk.java.net/browse/JDK-8058785

Webrev: http://cr.openjdk.java.net/~pkbalakr/shashi/8058785/webrev.00/

Thanks and regards,

Shashi



--

Best regards, Sergey.



--
Best regards, Sergey.

Re: [10] JDK-8058785: Nimbus disabled tooltip needs border

Reply via email to