On 09/25/2017 10:14 AM, Sergey Bylokhov wrote:

Hi, Semyon.
It seems that this change breaks the build, because it added a new non-default constructor to SynthModel.

open/make/jdk/src/classes/build/tools/generatenimbus/ObjectFactory.java:60: error: constructor SynthModel in class SynthModel cannot be applied to given types;
        return new SynthModel();
               ^
  required: XMLStreamReader
  found: no arguments
ObjectFactory.java was missed from the webrev. It should be deleted actually.
The updated webrev: http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.01/


On 9/20/17 20:11, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK10:

bug: https://bugs.openjdk.java.net/browse/JDK-8187599

webrev: http://cr.openjdk.java.net/~ssadetsky/8187599/webrev.00/

External JAXB was replaced by StAX parser in Nimbus L&F classes generation.

--Semyon





Reply via email to