On 07/11/2017 02:55, Prasanta Sadhukhan wrote:
AFAIK, all client property are by default "public" and I do not see any
documentation of any other property too. Do you see any other property
being documented in our javadoc?
They are "public" but it does not mean that all of them are specified.
Of-course it is unlikely to change, but it should be taken into account.
Small comments about the fix:
- Why we fire the notification before the actual change? I suggest to
create at least one auto test to check the behavior of new property.
- What about other classes which call BasicHTML.updateRenderer() in a
propertyChange? for example: BasicToolTipUI, SynthToolTipUI,
BasicButtonListener.
Regards
Prasanta
On 11/7/2017 7:37 AM, Alan Snyder wrote:
Is “graphicsConfig” a new public client property? I don’t see it
documented anywhere.
I think it should be public, or some public equivalent is needed,
because there are cases where applications need to recompute a layout
after the graphics configuration changes.
Alan
On Oct 30, 2017, at 11:12 PM, Prasanta Sadhukhan
<prasanta.sadhuk...@oracle.com> wrote:
Ok. Modified webrev to make sure data is recalculated by listening to
"graphicsConfig" change
http://cr.openjdk.java.net/~psadhukhan/8178025/webrev.03/
Regards
Prasanta
--
Best regards, Sergey.
