This test may be executed in the headless mode when the GTK l&f is installed but not supported. So it will be necessary to check that L&F is installed and supported, or to blindly set it and move to the next in case of exceptions. So I implements a second case since it is simpler.

On 02/01/2018 21:21, Prasanta Sadhukhan wrote:
Fix looks fine. For test, is it required to explicitly set the l&f, I guess we should check for installed l&f for a particular platform and not unnecessarily check for Aqua & Gtk in windows?

Regards
Prasanta
On 1/3/2018 3:16 AM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk10. The fix will be pushed to:
http://hg.openjdk.java.net/jdk/jdk10

Bug: https://bugs.openjdk.java.net/browse/JDK-8193673
Webrev can be found at: http://cr.openjdk.java.net/~serb/8193673/webrev.00

The fix for JDK-8189656[1] missed an update of Gensrc-java.desktop.gmk which compiles the property files for windows L&F.

[1] https://bugs.openjdk.java.net/browse/JDK-8189656




--
Best regards, Sergey.

Reply via email to