Hi Andrej, Thanks for the review.
I have made changes according to your suggestions. Please have a look. Webrev: http://cr.openjdk.java.net/~pbansal/5076761/webrev.03/ Regards, Pankaj Bansal -----Original Message----- From: Andrej Golovnin [mailto:andrej.golov...@gmail.com] Sent: Friday, January 5, 2018 4:33 PM To: Pankaj Bansal Cc: Semyon Sadetsky; swing-dev@openjdk.java.net; Sergey Bylokhov Subject: Re: <Swing Dev> [11] Review Request: JDK-5076761 : JList.setSelectedValue(null, ...) doesn't do anything Hi Pankaj, > Webrev: http://cr.openjdk.java.net/~pbansal/5076761/webrev.02/ src/java.desktop/share/classes/javax/swing/JList.java You can simplify the code in lines 2373 if((anObject == selectedValue) || 2374 (anObject != null && anObject.equals(selectedValue))) { and 2383 if ((anObject == object) || 2384 anObject!= null && anObject.equals(object)) { by using Objects.equals(Object, Object): And please add spaces in the line 2379 where needed (see http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-whitespace for details). Best regards, Andrej Golovnin
