Re: [11] Review Request: JDK- 8196443: [TEST_BUG] javax/swing/JList/BasicListTest.java has invalid tag

[Semyon Sadetsky]

+1

--Semyon


On 02/01/2018 02:09 AM, Pankaj Bansal wrote:

Hi Prasanta,

Thanks for the review.

<< You need to add this bug id to the test and also update/add the test year, while you are at it.

Done.

webrev: http://cr.openjdk.java.net/~pbansal/8196443/webrev.01/ <http://cr.openjdk.java.net/%7Epbansal/8196443/webrev.01/>

Regards,

Pankaj Bansal

*From:*Prasanta Sadhukhan
*Sent:* Thursday, February 1, 2018 3:22 PM
*To:* Pankaj Bansal; swing-dev@openjdk.java.net

*Subject:* Re: <Swing Dev> [11] Review Request: JDK- 8196443: [TEST_BUG] javax/swing/JList/BasicListTest.java has invalid tag

Hi Pankaj,

You need to add this bug id to the test and also update/add the test year, while you are at it.

Regards
Prasanta

On 2/1/2018 2:56 PM, Pankaj Bansal wrote:

    Hi All,

    Please review the test only fix for JDK 11.

    Bug:

    https://bugs.openjdk.java.net/browse/JDK-8196443

    Webrev:

    http://cr.openjdk.java.net/~pbansal/8196443/webrev.00/
    <http://cr.openjdk.java.net/%7Epbansal/8196443/webrev.00/>

    Issue:

    The test always fails with “Invalid Tag” error.

    Fix:

    The test is missing the “key” before the “headful” tag. A small
    spelling mistake is also corrected.

    Regards

    Pankaj Bansal