+1
On 21/02/2018 02:57, Jayathirth D V wrote:
Hi Prasanta,
Changes are fine.
Thanks,
Jay
-----Original Message-----
From: Prasanta Sadhukhan
Sent: Wednesday, February 21, 2018 3:23 PM
To: Jayathirth D V; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [11]
JDK-8198005:javax/swing/JFileChooser/7199708/bug7199708.java throws error
Thanks Jay. Yes, it was evident that was the case in your system, as the
JFileChooser itself did not come up and test times out.
I have modified the testcase further to increase timeout and do file deletion
also under try-finally so no files is kept undeleted.
http://cr.openjdk.java.net/~psadhukhan/8198005/webrev.01/
Regards
Prasanta
On 2/21/2018 3:04 PM, Jayathirth D V wrote:
Hi Prasanta,
As Sergey mentioned we are reaching timeout even before we finish creating all
the required temp files.
If we increase the default timeout from 2min to 4min the test passes.
Thanks,
Jay
-----Original Message-----
From: Sergey Bylokhov
Sent: Tuesday, February 20, 2018 10:41 PM
To: Prasanta Sadhukhan; Jayathirth D V; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [11]
JDK-8198005:javax/swing/JFileChooser/7199708/bug7199708.java throws
error
It seems it hangs even before the test starts:
at
java.io.WinNTFileSystem.createFileExclusively(java.base@11-internal/Na
tive
Method)
at java.io.File.createNewFile(java.base@11-internal/File.java:1024)
at bug7199708.createLargeFolder(bug7199708.java:152)
at bug7199708.main(bug7199708.java:64)
Probably the reason is a slow hdd and we need more time to create this number
of files?
On 20/02/2018 08:55, Prasanta Sadhukhan wrote:
Seems like in your case GC has triggered and suspended all threads
from execution causing timeout, which is not happening in my case.
Regards
Prasanta
On 2/20/2018 9:54 PM, Jayathirth D V wrote:
Hi Prasanta,
I ran the test 3 times and it still times out and throws the error.
I have attached timeout log for more info.
Thanks,
Jay
-----Original Message-----
From: Prasanta Sadhukhan
Sent: Tuesday, February 20, 2018 9:08 PM
To: swing-dev@openjdk.java.net
Subject: <Swing Dev> [11]
JDK-8198005:javax/swing/JFileChooser/7199708/bug7199708.java throws
error
Hi All,
Please review a test fix for an issue whereby it is seen that the
test times out on windows 7.
Issue seems to stem from calling File.deleteOnExit() for large
number of files, around 30000, which is causing the test to timeout.
Fix is to call File.delete(path) which causes the test to pass. It
is also verified that the new test also crashes if 7199708 fix is
backed out.
Bug: https://bugs.openjdk.java.net/browse/JDK-8198005
webrev: http://cr.openjdk.java.net/~psadhukhan/8198005/webrev.00/
Regards
Prasanta
--
Best regards, Sergey.
