+1
--Semyon
On 3/1/18 4:21 AM, Alexey Ivanov wrote:
Hello Semyon,
Thank you for your review.
The updated version:
http://cr.openjdk.java.net/~aivanov/8198777/webrev.1/
The case where the model is empty is covered in the paragraph above.
No change is necessary there.
Regards,
Alexey
On 01/03/2018 00:52, Semyon Sadetsky wrote:
Hello Alexey,
"height of the first cell" has relative meaning. I suggest to change
it to "height of cell with index 0".
Also, it would be nice to specify the case when the model is empty.
--Semyon
On 02/28/2018 01:39 PM, Alexey Ivanov wrote:
Hello,
Could you please review the fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK-8198777
webrev: http://cr.openjdk.java.net/~aivanov/8198777/webrev.0/
csr: https://bugs.openjdk.java.net/browse/JDK-8198822
It is a small fix to documentation of
JList.getPreferredScrollableViewportSize().
If either fixedCellWidth or fixedCellHeight are not set and the
model isn't empty, heuristics are used. The height is based one the
height of the first cell rather than fixedCellHeight.
Regards,
Alexey
