Looks good to me Prasanta.
On 01/03/18 11:35 PM, [email protected] wrote:
+1
--Semyon
On 3/1/18 10:01 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a test fix for an issue whereby it is seen that close
mnemonics for different locales was not working.
The issue has nothing to do with menmonics but with the test using
robot to press CTRL+SPACE to show system menu.
However, it is found that CTRL+SPACE is a known hotkey combination to
switch to chinese keyboard so
when this key combination is pressed, it is trying to find the
chinese locale mnemonics which is not present.
Proposed fix is to change the key combination to SHIFT+ESCAPE as it
also is used to show system menu
as per jdk implementation
http://hg.openjdk.java.net/jdk/client/file/838c11e59a38/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java#l853
http://hg.openjdk.java.net/jdk/client/file/838c11e59a38/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java#l866
Bug:https://bugs.openjdk.java.net/browse/JDK-8194943
webrev: http://cr.openjdk.java.net/~psadhukhan/8194943/webrev.00/
Regards
Prasanta
