Re: [11] JDK-8194873: right ALT key hotkeys no longer work in Swing components

[Prasanta Sadhukhan]

Hi Pankaj,

looks good. but it still does not test JMenuItem as I can see. Did you 
check if you have some menu items inside JMenu and set mnemonic, does 
Right Alt key works?

Regards
Prasanta
On 4/10/2018 3:15 PM, Pankaj Bansal wrote:
Hello Andrej,

Thanks for the quick review. Yes, it does not sense to apply || on same value. 
It was a typo. Thanks for pointing it out.
Webrev:
http://cr.openjdk.java.net/~pbansal/8194873/webrev.02/


Regards,
Pankaj Bansal

-----Original Message-----
From: Andrej Golovnin [mailto:andrej.golov...@gmail.com]
Sent: Tuesday, April 10, 2018 2:18 PM
To: Pankaj Bansal
Cc: Prasanta Sadhukhan; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [11] JDK-8194873: right ALT key hotkeys no longer work 
in Swing components

Hi Pankaj,

Webrev:

http://cr.openjdk.java.net/~pbansal/8194873/webrev.01/
src/java.desktop/windows/native/libawt/windows/awt_Component.cpp

3540         BOOL altIsDown = ((modifiers &
java_awt_event_InputEvent_ALT_DOWN_MASK) ||
3541                             (modifiers &
java_awt_event_InputEvent_ALT_DOWN_MASK));

Applying '||' on the same value does not make sense. I think the line
3541 should use 'java_awt_event_InputEvent_ALT_GRAPH_DOWN_MASK':

3541                             (modifiers &
java_awt_event_InputEvent_ALT_GRAPH_DOWN_MASK));

Best regards,
Andrej Golovnin