+1 -----Original Message----- From: Prasanta Sadhukhan Sent: Friday, June 8, 2018 10:16 AM To: Sergey Bylokhov <sergey.bylok...@oracle.com>; swing-dev@openjdk.java.net Subject: Re: <Swing Dev> [11] Review Request: 6608234 SwingWorker.get throws CancellationException
looks good to me. Regards Prasanta On 6/8/2018 6:13 AM, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk11. > > Bug: https://bugs.openjdk.java.net/browse/JDK-6608234 > Webrev: http://cr.openjdk.java.net/~serb/6608234/webrev.00 > CSR: https://bugs.openjdk.java.net/browse/JDK-8204587 > > The SwingWorker.get(XX) methods copy the text of exceptions from the > parent class, but the text for CancellationException is not copied, > because CancellationException is unchecked exception and not declared > in the method. > > The similar bug was fixed for the parent class[1], so I used the same > approach and add a "@throws CancellationException {@inheritDoc}" to > the methods. > > [1] https://bugs.openjdk.java.net/browse/JDK-6299797 >
