Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

[Prasanta Sadhukhan]

Hi Krishna,

One more thing...it is mentioned here

58  * Java Licensees may want to provide a different implementation of
  59  * FileSystemView to better handle a given operating system

If this class is ever extended by applications, then would it not be source 
incompatible change as there is no default
implementation of the new method?

Regards
Prasanta

On 8/27/2018 5:05 PM, Krishna Addepalli wrote:

Hi Prasanta,

Thanks for pointing those out. Corrected them in the new webrev: http://cr.openjdk.java.net/~kaddepalli/8182041/webrev01/ <http://cr.openjdk.java.net/%7Ekaddepalli/8182041/webrev01/>

Krishna

*From:*Prasanta Sadhukhan
*Sent:* Monday, August 27, 2018 4:50 PM

*To:* Krishna Addepalli <krishna.addepa...@oracle.com>; swing-dev@openjdk.java.net *Subject:* Re: <Swing Dev> [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

Hi Krishna,

Quick comments:
@since 10 should be @since 12 in API javadoc
Is ShellFolderQueriesSecurityManagerTest a manual test as you mentioned

@run main/manual/


Regards
Prasanta

On 8/27/2018 4:24 PM, Krishna Addepalli wrote:

    Hi All,

    Please review fix for JDK10 (the changes involve AWT and Swing):

    bug: https://bugs.openjdk.java.net/browse/JDK-8182041

    webrev: http://cr.openjdk.java.net/~kaddepalli/8182041/webrev00/
    <http://cr.openjdk.java.net/%7Ekaddepalli/8182041/webrev00/>

    New API method was added to query shortcut panel entries for
    JFileChooser, since ShellFolder is internal class which is not
    publicly accessible.

    Thanks,

    Krishna