Looks fine.

On 03/10/2018 07:35, Muneer Kolarkunnu wrote:
Hi Sergey,

I added image validation, basically it captures image screen shot and checking 
some 10 pixels from inner area of the image are not default background color.
New webrev : http://cr.openjdk.java.net/~akolarkunnu/8209499/webrev.01/

Regards,
Muneer

-----Original Message-----
From: Alexandre (Shura) Iline
Sent: Thursday, August 30, 2018 10:45 PM
To: Sergey Bylokhov <sergey.bylok...@oracle.com>
Cc: Muneer Kolarkunnu <abdul.kolarku...@oracle.com>; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 
EditorPaneDemo

Thank you - makes sense now.

On Aug 30, 2018, at 10:10 AM, Sergey Bylokhov <sergey.bylok...@oracle.com> 
wrote:

Hi, Alexandr.
I assume that one of the purpose of the test is to check that the html 
(including images) are correctly loaded to the EditorPane and present it to the 
user.
If there are some issues like
- absent of the image files
- errors in the file system
- bugs in EditorPane, etc
which prevent the correct representation of the text in EditorPane, then the 
test should fail. But the test passed when I applied the patch without images.

On 30/08/2018 09:38, Alexandre (Shura) Iline wrote:
I am trying to understand the use case.
The images would be checked in with the rest of the code and thus, normally, 
the images will be available.
Are you anticipating a scenario when the images would not be present with the 
rest of the code?
— or —
Do you want to add a test to check that the images are not actually displayed 
on screen?
Shura

On 19/08/2018 22:05, Muneer Kolarkunnu wrote:
Gentle Reminder.
Regards,
Muneer
*From:*Muneer Kolarkunnu
*Sent:* Tuesday, August 14, 2018 10:35 PM
*To:* swing-dev@openjdk.java.net
*Subject:* <Swing Dev> [12] RFR [TEST][JDK-8209499] Create test for
SwingSet3 EditorPaneDemo Hi All, Please review the following, a new
client sanity test case:
Task: https://bugs.openjdk.java.net/browse/JDK-8209499
Webrev
Link:http://cr.openjdk.java.net/~akolarkunnu/8209499/webrev.00/
<http://cr.openjdk.java.net/%7Eakolarkunnu/8209499/webrev.00/>
Summary: This is a new test to automate testing of SwingSet3 EditorPaneDemo.
Please see the bug description for the scenarios automated.
test/jdk/sanity/client/SwingSet/src/EditorPaneDemoTest.java – This is the real 
test code, all other files are copied from swingset3 demo.
Regards,
Muneer


--
Best regards, Sergey.


--
Best regards, Sergey.



--
Best regards, Sergey.

Reply via email to