Hi Shashi, 1. Please add "@key headful" to the test. 2. I don’t think you need to replace the waitForIdle call with delay. You may choose to add delay in addition to waitForIdle. 3. Minor nit: replace () -> createAndShowGUI() with method reference.
Thanks, Krishna -----Original Message----- From: Shashidhara Veerabhadraiah Sent: Wednesday, October 31, 2018 3:34 PM To: swing-dev@openjdk.java.net; awt-...@openjdk.java.net Subject: <Swing Dev> [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ Fix: As the initial bug analysis said in the bug comments, it is a timing issue where in the choice menu remains opened even though the escape key is pressed. After removing the applet dependency and using the swing utilities to order the GUI creation and sending the key events with a delay is fixing the problem. This test was successfully run on Windows 10, Mac 10.13 and Ubuntu 16.04. Thanks and regards, Shashi
