Hi Sergey,

On 01-Nov-18 12:25 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
On 31/10/2018 11:40, Prasanta Sadhukhan wrote:
This is a regression ofJDK-8203281: <https://bugs.openjdk.java.net/browse/JDK-8203281>[Windows] JComboBox change in ui when editor.setBorder() is called where combobox arrow button height is reduced by 2

It is reduced if the EmptyBorder is in use. Should the current fix use the similar check?

We can use the similar check in the fix. Updated webrev
http://cr.openjdk.java.net/~psadhukhan/8213116/webrev.1/

Regards
Prasanta
[http://hg.openjdk.java.net/jdk/client/file/20e47d686221/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsComboBoxUI.java#l381] but the minimum size of combobox is set to old values which was added during<https://bugs.openjdk.java.net/browse/JDK-8179027> JDK-8179027: <https://bugs.openjdk.java.net/browse/JDK-8179027>JComboBox too small under Windows LAF
which was done to address regression caused by
JDK-6490753: <https://bugs.openjdk.java.net/browse/JDK-6490753> Vista:JComboBox doesn't looks as native combobox in different states of component.

Now, JDK-8203281 <https://bugs.openjdk.java.net/browse/JDK-8203281> was also a regression caused by JDK-6490753 <https://bugs.openjdk.java.net/browse/JDK-6490753> so the combobox size needs to be altered in the fix done for JDK-8179027 <https://bugs.openjdk.java.net/browse/JDK-8179027> to make sure the values are compatible.

Bug: https://bugs.openjdk.java.net/browse/JDK-8213116
webrev: http://cr.openjdk.java.net/~psadhukhan/8213116/webrev.0/

Regards
Prasanta



Reply via email to