Looks fine.

On 04/11/2018 21:24, Muneer Kolarkunnu wrote:
Gentle Reminder.

Regards,

Muneer

*From:* Muneer Kolarkunnu
*Sent:* Wednesday, October 31, 2018 10:40 AM
*To:* [email protected]
*Cc:* Aleksandre Iline <[email protected]>
*Subject:* <Swing Dev> [12] RFR [JDK-8213168] Enable different look and feel 
tests in SwingSet3 demo test FileChooserDemoTest

Hi All,

Please review fix for the task:

Task: https://bugs.openjdk.java.net/browse/JDK-8213168

Webrev: http://cr.openjdk.java.net/~akolarkunnu/8213168/webrev.00/

Changes in jemmy file JFileChooserOperator is already checked in jemmy repo by 
task http://hg.openjdk.java.net/code-tools/jemmy/v2/rev/93cfbd0e4d48 .

Description of fixes:

There are multiple issues in different L&Fs.

GTK and Motif L&F:

1) There are two JLists according JDK implementation, one is to list folders 
and second one one is to list files, but current jemmy JFileChooserOperator 
implementation didn't consider this, it expects only one JList that is to list 
files.

2) Open button text is "OK", not "OPEN"

Aqua, GTK and Motif L&F:

1) GO Home, Up Level button, List and Details view functionalities are not 
available.

Windows & Windows Classic L&F:

1) There is no 'Go Home' button, but there is a toggle button to go desktop. In 
Windows platform 'Go Home' button usually(In metal and nimbus L&F) navigates to 
Desktop only.

2) List and Details views are implemented as a popup menu item in JDK, not 
toggle buttons.

Regards,

Muneer



--
Best regards, Sergey.

Reply via email to