Looks fine.
On 08/11/2018 22:53, Shashidhara Veerabhadraiah wrote:
Hi Sergey, Here is the updated Webrev.
http://cr.openjdk.java.net/~sveerabhadra/8198624/webrev.01/
I have kept the frame layout same as the layout that was used for the applet so
that it looks the same as earlier.
Thanks and regards,
Shashi
-----Original Message-----
From: Sergey Bylokhov
Sent: Tuesday, November 6, 2018 2:06 AM
To: Shashidhara Veerabhadraiah <[email protected]>;
[email protected]
Subject: Re: <Swing Dev> [12] JDK-8198624:
java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on
mac
Hi, Shashi.
A few notes:
1. All Swing components are still created on non-EDT thread.
2. Why did you change this line:
this.setLayout (new BorderLayout ());
to this:
frame.setLayout (new BorderLayout ());
The first line was related to the applet, and actually it was unrelated
to the frame.
3. Why did you drop this line?
Util.waitForCondition
4. invokeLater() is sued in the "dispose()" method?
On 05/11/2018 08:22, [email protected] wrote:
Hi All, Please review test fix for the below bug.
Bug: https://bugs.openjdk.java.net/browse/JDK-8198624
Webrev: http://cr.openjdk.java.net/~sveerabhadra/8198624/webrev.00/
The problem was the swing components were used in the main thread, causing
syncing issues between the key press events and swing components. The test has
been reordered to the proper use of the swing components.
Thanks and regards,
Shashi
--
Best regards, Sergey.
