Looks good to me.
Regards
Prasanta
On 19-Nov-18 12:26 PM, Krishna Addepalli wrote:
Hi All,
Can I have the new webrev reviewed? As per suggestions, I have removed
all the files not in client area.
Thanks,
Krishna
*From:*Krishna Addepalli
*Sent:* Thursday, October 25, 2018 11:54 AM
*To:* Philip Race <[email protected]>
*Cc:* jonathan Gibbons <[email protected]>;
[email protected]
*Subject:* Re: <Swing Dev> [12]RFR JDK-8212882: links to tutorial
should be updated to use https:
Hi All,
I have removed all non-client files and created a new webrev:
http://cr.openjdk.java.net/~kaddepalli/8212882/webrev01/
<http://cr.openjdk.java.net/%7Ekaddepalli/8212882/webrev01/>
Thanks,
Krishna
On 25-Oct-2018, at 10:24 AM, Philip Race <[email protected]
<mailto:[email protected]>> wrote:
Actually you should remove all those from this review and let jjg file
bugs on those areas. It is possible they were included by accident
but I don't
see where you got the hotspot ones from and they are purely code
comments NOT
anything official.
Let's just fix our own code and not presume to fix some one else's
in the same push.
-phil.
On 10/24/18, 9:23 PM, Sergey Bylokhov wrote:
Hi, Krishna
I think you need to include more groups to this review:
hotspot-dev, core-libs-dev and security-dev.
On 23/10/2018 23:21, Krishna Addepalli wrote:
Hi All,
Please review a trivial fix of updating the links to https.
Bug: https://bugs.openjdk.java.net/browse/JDK-8212882
Webrev:
http://cr.openjdk.java.net/~kaddepalli/8212882/webrev00/
<http://cr.openjdk.java.net/%7Ekaddepalli/8212882/webrev00/>
Thanks,
Krishna
