Hi Alexey,

Here's the updated webrev catering to your comments:
http://cr.openjdk.java.net/~psadhukhan/8213049/webrev.3/

Regards
Prasanta
On 04-Dec-18 12:48 AM, Alexey Ivanov wrote:
Hi Prasanta,

Thank you for updating the files.
I've got some more comments:

*properties.html*

There should be </tbody> between these lines:
116 </tr>
</tbody>
117 </table>

The second table should also have <thead>:
 121 <caption>Secondary colors used in Nimbus Look And Feel </caption>
<thead>
 122 <tr><th>Key</th><th>Value</th><th>Preview</th></tr>
</thead>
<tbody>
 123 <tr>

You have already added closing </tbody> into the second table.

* </tbody> can be omitted in these cases, however, it's present in the majority of cases in Swing docs.


*componentProperties.html*

I propose adding empty paragraph between two tables:
<p>&nbsp;</p>
to visually separate them in these cases:

167 </table>
168
169 <table border="1">
170 <caption>JComboBox Specific Properties</caption>

794 </table>
795
796 <table border="1">
797 <caption>JScrollBar Specific Properties</caption>


Regards,
Alexey

On 03/12/2018 16:53, Prasanta Sadhukhan wrote:
Hi Alexey,

Thanks for the pointers. Updated webrev hopefully catering to all your comments
http://cr.openjdk.java.net/~psadhukhan/8213049/webrev.2/

Regards
Prasanta
On 03-Dec-18 9:25 PM, Alexey Ivanov wrote:
<SNIP>


Reply via email to