Looks fine.
On 17/01/2019 10:29, Pankaj Bansal wrote:
Hi All,
Please review the following fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214765
webrev: http://cr.openjdk.java.net/~pbansal/8214765/webrev.00/
Issue:
The icons are not being displayed in System TrayIcon for warning, error, info
MessageTypes etc. This issue is being observed in OEL with gtk3.
Fix:
The icon names used in TrayIcon messages for GTKLookAndFeel are mentioned in
InfoWindow.java. These icon names were changed from gtk3 version 3.10. This
change was not incorporated in jdk and so the icons are not being displayed
properly in OEL. In Ubuntu, there are symbolic links present in icon themes
with old names which link to actual icons with correct names. So the icons are
being displayed successfully in Ubuntu through these symbolic links though the
icon names should have been changed according to gtk3 specification change.
https://developer.gnome.org/gtk2/stable/gtk2-Stock-Items.html#GTK-STOCK-DIALOG-ERROR:CAPS
https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-DIALOG-ERROR:CAPS
I have tested this on Ubuntu 18.04, Ubuntu 16.04 and OEL 7.5 with both gtk2 and
gtk3
Regards,
Pankaj Bansal
--
Best regards, Sergey.
