ok. +1
Regards
Prasanta
On 22-Jan-19 2:27 PM, Vikrant Agarwal wrote:
Hi Prasanta,
I ran the updated test on Windows, Ubuntu and Mac and the test ran fine.
Best Regards,
Vikrant
-----Original Message-----
From: Prasanta Sadhukhan
Sent: Tuesday, January 22, 2019 1:55 PM
To: Vikrant Agarwal <[email protected]>
Cc: [email protected]
Subject: Re: <Swing Dev> [13] RFR [JDK-8217377]
javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation
exception
Hi Vikrant,
Which platforms you have run the test? Only in linux or in all win,linux and
mac platforms? Iguess it will be better if you run the updated test in all 3,
if not run already.
Regards
Prasanta
On 21-Jan-19 12:53 PM, Vikrant Agarwal wrote:
Hi Sergey,
I have updated the test.
Updated Webrev: http://cr.openjdk.java.net/~vagarwal/8217377/webrev.1/
Best Regards,
Vikrant
-----Original Message-----
From: Sergey Bylokhov
Sent: Saturday, January 19, 2019 3:52 AM
To: Vikrant Agarwal <[email protected]>;
[email protected]
Subject: Re: <Swing Dev> [13] RFR [JDK-8217377]
javax/swing/JPopupMenu/6583251/bug6583251.java failed with
UnsupportedOperation exception
Hi, Vikrant.
Can you please dispose the frame at the end of the test, something like this:
SwingUtilities.invokeAndWait(new Runnable() {
public void run() {
frame.dispose();
}
});
On 18/01/2019 05:47, Vikrant Agarwal wrote:
Hi All,
Please review this fix for JDK-8217377:
Bug: https://bugs.openjdk.java.net/browse/JDK-8217377
Webrev: http://cr.openjdk.java.net/~vagarwal/8217377/webrev.0/
Summary: test/jdk/javax/swing/JPopupMenu/6583251/bug6583251.java was failing
with UnsupportedOperationException wherever SystemTray/Tray icon were
unsupported.
This fix adds a check to ensure that SystemTray is supported before testing and
handles UnsupportedOperationException which is thrown if SystemTray/Tray icon
is not supported.
Best Regards,
Vikrant
