Hi Sergey, The fix looks good. However, I think, its good that if you add a test case for this fix. The reproducer provided in the bug is good enough(ofcourse, with some addition of pass fail criteria as for manual tests).
Thanks, Krishna > On 31-Jan-2019, at 4:09 AM, Phil Race <[email protected]> wrote: > > +1 > > -phil. > > On 1/24/19 9:16 AM, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for jdk 13. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8061381 >> Fix: http://cr.openjdk.java.net/~serb/8061381/webrev.00 >> >> This fix adds the support of swing menu accelerators for Voice Over on macOS >> (note that swing menu is used when the "apple.laf.useScreenMenuBar" is >> false). >> If the property "apple.laf.useScreenMenuBar" is true we use the native menu >> which >> is already supported by the VoiceOver. >> >> The fix will convert the accelerator to the string which is passed to the >> VO, the logic >> which is used to access the KeyStroke and convert it to the string is >> similar to what >> we use on windows in the accessbridge. >> >
