Hi, Prasanta.

The test has some assumptions which is no necessary true:
 - it might be executed outside of our internal network
 - the background color of 100x100 on https://www.google.com is not necessary 
white(this is not guarantied)

On 21/02/2019 00:34, Prasanta Sadhukhan wrote:
Hi All,

Please review a fix for an issue where it is seen that some webpage shows wrong 
background color when displayed in JEditorPane.

It seems that some webpage can have #rgb [as in #fff] as CSS attributes which 
when parsed and passed to hexToColor() it is decoded as 0x000fff resulting in 
primarily blue background instead of white as desired.
Now, hexToColor() is only able to handle 24 bit hex string as in #FFFFFF but 
not 12bit hexstring. So, fix is to make it recognize #fff and use 
Color.decode() to decode it correctly to 0xffffff.

Bug: https://bugs.openjdk.java.net/browse/JDK-8213781
webrev: http://cr.openjdk.java.net/~psadhukhan/8213781/webrev.0/

Regards
Prasanta


--
Best regards, Sergey.

Reply via email to