Please find modified webrev where I removed the hardcoded proxy setting.
I am now relying on jtreg proxyHost,proxyPort to run the test which will
also allow people to run in standalone mode.
http://cr.openjdk.java.net/~psadhukhan/8213781/webrev.1/
I have also added the comment in the code as decided in the other review.
Regards
Prasanta
On 21-Feb-19 10:33 PM, Prasanta Sadhukhan wrote:
On 21-Feb-19 10:31 PM, Sergey Bylokhov wrote:
On 21/02/2019 08:46, Prasanta Sadhukhan wrote:
But it can always be changed if somebody wants to run as a
standalone test. There are many test in java/net, sun/security where
they explicitly do setProperty(proxy) [for ex,
java/net/ProxySelector/B6737819.java,
sun/security/ssl/InputRecord/ClientHelloRead.java] as I am doing in
the test.
Some of those tests set it to the localhost, others which uses proxy
are in the closed repo.
Can you please elaborate as to what the other way of sending proxy
to the test, if you are aware?
You should not set a proxy and access the google.com. The test should
run w/o dependency on the external resource.
But the bug manifest itself only for some webpage and I only know of
google.com as mentioned in bug report, so I have to access google.com.
I will try to send proxyHost,proxyPort via jtreg if that is fine with
you.
Regards
Prasanta
