Hi Vikrant. could you please explain how 'test/jdk/sanity/client/TEST.ROOT.template' is used? if it's not used at all, I'd prefer to delete this file for good.
I also have kinda same question to 'TEST.properties' file. AFAIR jtreg doesn't extending 'keys' in 'TEST.properties' files, which means all keywords must be listed in 'TEST.ROOT' file, and using of any other unregistered keywords leads to 'Error. Parse Exception: Invalid key: ...'. 'screenshots' isn't registered in test/jdk/TEST.ROOT, having it in 'test/jdk/sanity/client/TEST.properties' has no effect, so 'test/jdk/sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java' (the only test w/ screenshots) can't be executed and will always fail w/ error status. so I'm wondering if you doing something w/ test/jdk/sanity/client/ before running these tests. Thanks, -- Igor > On Feb 21, 2019, at 9:56 PM, Vikrant Agarwal <vikrant.v.agar...@oracle.com> > wrote: > > Hi All, > Please review this small fix for JDK-8219552 > <https://bugs.openjdk.java.net/browse/JDK-8219552>: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8219552 > <https://bugs.openjdk.java.net/browse/JDK-8219552> > Webrev: http://cr.openjdk.java.net/~vagarwal/8219552/webrev.0/ > <http://cr.openjdk.java.net/~vagarwal/8219552/webrev.0/> > Summary: Removed jtreg requiredVersion field from files in > test/jdk/sanity/client/ as it is redundant because jtreg requiredVersion is > specified in test/jdk/TEST.ROOT which is being updated by JDK-8219417 > <https://bugs.openjdk.java.net/browse/JDK-8219417> > Best Regards, > Vikrant
