On 11/06/2019 14:26, Sergey Bylokhov wrote:
Is style="font-weight:normal" necessary for each <th> inside <tbody>?
It works, thank you for suggestion: http://cr.openjdk.java.net/~serb/8225146/webrev.02 http://cr.openjdk.java.net/~serb/8225146/webrev.02/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
I tried to set the style to tbody itself and it does not work, will check your suggestion below. But before that, I would like to confirm that the "bold-version"(webrev.00) is not good enough?(The previous version defaulted to bold rendering.) If yes, is it possible to add a stylesheet to handle this for the entire page? <style type="text/css"> tbody th { font-weight: normal; } </style> Should the title of the page use title capitalization? In this case, “Used” should be capitalized; at the same time “and” should be lower-case. Thus the title would be “Colors Used in Nimbus Look and Feel”. “How to Set the Look and Feel” [1] article in the Java Tutorials follows this capitalization style. Regards, Alexey [1] https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html On 11/06/2019 12:41, Sergey Bylokhov wrote:Hello. Please review the fix for JDK 13. Bug: https://bugs.openjdk.java.net/browse/JDK-8225146 Fix: http://cr.openjdk.java.net/~serb/8225146/webrev.01 Accessibility support was improved for "nimbus/doc-files/properties.html" file, the next changes were done: - I have renumbered old h1 tags to h2 and added one h1 tag, which contains the main title of the page - Each column now has scope="col" attribute - The content of the "Key" column was marked as row header, so "scope=row" was added to each related row - I made the caption of the table invisible since it mostly duplicates the text of the h2 header, but even invisible it will be used by the screen reader - Note that in each row in the "Preview" column I have added "aria-label="Color preview"", otherwise a11y validator complains about empty data cell Old page: http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/old/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html New page: http://cr.openjdk.java.net/~serb/8225146/webrev.01/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html BTW probably this variant looks better? It uses default styles for the "th" tag for rows and contains "less code", personally I like it better: http://cr.openjdk.java.net/~serb/8225146/webrev.00/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html http://cr.openjdk.java.net/~serb/8225146/webrev.00
-- Best regards, Sergey.
