Hi Sergey, I agree the generic documentation should be updated. I have opened https://bugs.openjdk.java.net/browse/JDK-8232880 <https://bugs.openjdk.java.net/browse/JDK-8232880> to track that. Also I would like to update this particular test, as well: http://cr.openjdk.java.net/~dmarkov/8232605/webrev.01/ <http://cr.openjdk.java.net/~dmarkov/8232605/webrev.01/>
Thanks, Dmitry > On 22 Oct 2019, at 19:19, Sergey Bylokhov <[email protected]> wrote: > > Hi, Dmitry. > > I think it is better to describe this requirement in some generic > documentation rather than single test. > It is applicable to the manual and automatic tests. > Probably it is time to add a new block related to client to > open/doc/testing.md? > > On 10/22/19 3:45 am, Dmitry Markov wrote: >> Hi Sergey, >> You are right, if the system reservation for “CTRL” + “F1” key sequence is >> disabled then the test works as expected. I have updated the test with some >> additional instructions for this case: >> http://cr.openjdk.java.net/~dmarkov/8232605/webrev.01/ >> <http://cr.openjdk.java.net/~dmarkov/8232605/webrev.01/> >> Can you take a look, please? >> Thanks, >> Dmitry >>> On 21 Oct 2019, at 20:11, Sergey Bylokhov <[email protected] >>> <mailto:[email protected]> <mailto:[email protected] >>> <mailto:[email protected]>>> wrote: >>> >>> Hi, Dmitry. >>> >>> I just tried this test on macOS and it works fine, can you please clarify >>> by what >>> operation this shortcut is reserved? >>> If it is reserved by operation from System Preferences -> Keyboard -> >>> Shortcuts, >>> then the right thing to do is to disable all system shortcuts. It is >>> applicable to >>> all test systems win/lin/mac/etc. >>> >>> On 10/21/19 2:51 am, Dmitry Markov wrote: >>>> The key sequence “CTRL” + “F1”, which is used to show/hide tooltip message >>>> in Java GUI applications, is reserved by the system on OSX platform. The >>>> following test, which uses this key binding, should NOT be executed on Mac >>>> to avoid any confusion: >>>> open/test/jdk/javax/swing/ToolTipManager/JMenuItemToolTipKeyBindingsTest/JMenuItemToolTipKeyBindingsTest.java >>> >>> >>> -- >>> Best regards, Sergey. > > > -- > Best regards, Sergey.
