Hi Sergey, Thank you for the comment. Please find webrev.02. http://cr.openjdk.java.net/~tnakamura/8234386/webrev.02
Thanks, Toshio Nakamura Sergey Bylokhov <[email protected]> wrote on 2019/11/22 07:07:03: > From: Sergey Bylokhov <[email protected]> > To: Toshio 5 Nakamura <[email protected]> > Cc: [email protected] > Date: 2019/11/22 07:07 > Subject: [EXTERNAL] Re: <Swing Dev> RFR: JDK-8234386: [macos] NPE > was thrown at expanding Choice from maximized frame > > It looks like after the .01 version you can inline the usage of > Toolkit.getDefaultToolkit(), it is only used inside > "if (!canPopupOverlapTaskBar()) {". > > On 11/21/19 5:10 am, Toshio 5 Nakamura wrote: > > Hi Sergey, > > > > Thank you for the review. > > How about the fix in webrev.01? > > > > To calculate Insets of default screen could be same as to set gc > of default screen device, I think. > > I found similar code in RepaintManager. > > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Etnakamura_8234386_webrev.01&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=EcWdPZy4cTg6EdgySmL927nv8uZ093ROkndF4CzQVgA&s=S8YSlNsNy2b7ijCj6YYZuVrNMGbPvzm6DryWYDD6Evw&e= > > > > Thanks, > > Toshio Nakamura > > > > Sergey Bylokhov <[email protected]> wrote on 2019/11/21 17:42:39: > > > > > From: Sergey Bylokhov <[email protected]> > > > To: Toshio 5 Nakamura <[email protected]>, [email protected] > > > Date: 2019/11/21 17:42 > > > Subject: [EXTERNAL] Re: <Swing Dev> RFR: JDK-8234386: [macos] NPE > > > was thrown at expanding Choice from maximized frame > > > > > > Hi, Toshio. > > > > > > In a few lines above your fix, the code takes care of null GC > and use the main > > > screen size as a screen bound, so I think your change should calculate > > > Insets for the main screen as well instead of using zeros. > > > > > > BTW probably GraphicsEnvironment.getMaximumWindowBounds() couldbe used at > > > line 336 additionally to your fix. > > > > > > On 11/19/19 7:55 pm, Toshio 5 Nakamura wrote: > > > > Hi All, > > > > > > > > Could you review the following fix? Also, I'd like to ask a > > > sponsor of this fix, since I'm not a committer. > > > > > > > > Bug: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8234386&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=EcWdPZy4cTg6EdgySmL927nv8uZ093ROkndF4CzQVgA&s=xMb6RAw3ZUTLrq_NsxDopE8Z7K78_DOfJoKrASJZ9Yg&e= > > > > Webrev: https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Etnakamura_8234386_webrev.00&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw&m=EcWdPZy4cTg6EdgySmL927nv8uZ093ROkndF4CzQVgA&s=iKFVIOUqx-_YCtM9dkS08fKkTyZFuoBdUK-GM-ljDhM&e= > > > > > > > > Issue: > > > > NullPointerException was thrown when Choice was expanded from > > > maximized Frame. > > > > > > > > Fix: > > > > Simply adding a null check to JPopupMenu. When the frame was > > > maximized and expanding > > > > Choice component, GraphicsConfiguration parameter can be null. > > > Detailed description was in JBS. > > > > > > > > Thanks, > > > > Toshio Nakamura > > > > > > > > > > > > > -- > > > Best regards, Sergey. > > > > > > > > -- > Best regards, Sergey. >
