Looks good to me -----Original Message----- From: Philip Race Sent: Thursday, December 5, 2019 9:12 AM To: Sergey Bylokhov Cc: [email protected] Subject: Re: <Swing Dev> [14] Review Request: 7124307 JSpinner and changing value by mouse
+1 -phil On 12/4/19, 7:31 PM, Sergey Bylokhov wrote: > Any volunteers to review? =) > > On 11/13/19 2:49 pm, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for JDK 14. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-7124307 >> Fix: http://cr.openjdk.java.net/~serb/7124307/webrev.00 >> >> The bug which was fixed on win/lin long time ago[1] was found by the >> related test on macOS+Aqua L&F, the root cause and the fix are >> exactly the same[2]. >> >> The test is moved to the open repo(I have added a loop to check all >> installed L&Fs), mach5 is green. >> >> >> [1] https://bugs.openjdk.java.net/browse/JDK-4788637 >> [2] >> https://bugs.openjdk.java.net/browse/JDK-4788637?focusedCommentId=122 >> 12891&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-ta >> bpanel#comment-12212891 >> > >
