Hello Tejpal,
I think you need to iterate over the full "tables" array instead of just
using the tables[0] as is being done in entrySet function in same class.
Also, you need to create a copy of the key set like entrySet function
instead of returning the original handle.
Also, please follow the 80 chars max per line convention in testcase added.
Regards,
Pankaj
On 05/03/20 4:26 PM, Tejpal Rebari wrote:
Hi All,
Please review the following fix for jdk15.
Bug: https://bugs.openjdk.java.net/browse/JDK-8146330
Webrev :http://cr.openjdk.java.net/~trebari/swing/8146330/webrev0/
<http://cr.openjdk.java.net/%7Etrebari/swing/8146330/webrev0/>
Issue : The two Methods UIDefaults.keys() and
UIDefault.keySet() returns different size.
Keys() returns Enumeration of keys in the Hashtable and
keySet() returns set view of keys.
For AquaLookAndFeel UIDefaults.keys() returns 719 keys while
UIDefault.keySet() returns 0 keys.
For other LookAndFeel UIDefaults.keys() returns different values but
the UIDefault.keySet() returns 0.
Fix : There is a keys() method in MultiUIDefaults class which returns
the enumeration of the keys but there is no such method for keySet().
Fix is to add the keySet() method in MultiUIDefaults which will return
the keySet of uiDefaults.
Test : Tested on Mac,Windows and Linux.
Added a test to test on all installed look and feels
Regards
Tejpal
