Looks good to me though the webrev02 was also good enough and easy to read as second case is anyway going to fail if first case fails. You can push webrev03 as well.
Regards, Pankaj From: Tejpal Rebari Sent: Friday, March 13, 2020 4:31 PM To: Jayathirth D v <jayathirth....@oracle.com> Cc: swing-dev@openjdk.java.net Subject: Re: <Swing Dev> RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet() Hi Jay, On 13-Mar-2020, at 3:55 PM, Jayathirth D v <HYPERLINK "mailto:jayathirth....@oracle.com"jayathirth....@oracle.com> wrote: Hi Tejpal, Test case is not verifying all failure scenarios properly (If both test cases fail exception will be thrown only for first test failure) Make sure that you verify each test case failure and print appropriate message. Source change looks good to me. Thanks, Jay I have updated the test to properly print the error message according to test cases failure. Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev3/ Thanks Tejpal On 13-Mar-2020, at 3:36 PM, Sergey Bylokhov <HYPERLINK "mailto:sergey.bylok...@oracle.com"sergey.bylok...@oracle.com> wrote: Looks fine. On 3/13/20 2:30 am, Tejpal Rebari wrote: Hi Sergey, On 11-Mar-2020, at 5:27 AM, Sergey Bylokhov <HYPERLINK "mailto:sergey.bylok...@oracle.com"sergey.bylok...@oracle.com<mailto:sergey.bylok...@oracle.com>> wrote: On 3/10/20 1:04 am, Tejpal Rebari wrote: I am not getting how to cover this in the test. I that additional call is necessary, then it should be possible to trigger it by the test. -- Best regards, Sergey. I have updated the test to check for super.keySet(). Now the test will check for 1. defaults key size returned by the UIManager.getDefaults() 2. key size after writing an additional value to the UIManager.getDefaults() Verified that the tests fails after the fix of http://cr.openjdk.java.net/~trebari/swing/8146330/webrev1/ and passes after adding set.addAll(super.keySet()); Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev2/ Thanks Tejpal -- Best regards, Sergey.
