Look good to me
-Pankaj
On 11/04/20 9:46 PM, Prasanta Sadhukhan wrote:
On 11-Apr-20 8:08 PM, Sergey Bylokhov wrote:
Hi, Prasanta.
Not sure that "waitForIdle()" should be removed at line 107, it waits
till the moment the window became visible,
and w/o it the Util.getCenterPoint may return wrong coordinates.
It is also unclear how the robot.delay(500); after the "hitKeys" will
help, since the buttons
were pressed already, and we additionally will wait for what?
OK. I have added waitForIdle() but I have retained delay as we still
need to hit VK_C after SHIFT+ESC.
It passes 100 iterations of mach5 testing.
http://cr.openjdk.java.net/~psadhukhan/8242526/webrev.1/
Regards
Prasanta
On 4/11/20 7:13 am, Prasanta Sadhukhan wrote:
Hi All,
Please review a test fix for an issue seen in PIT where the test is
failing on ubuntu 18.04 on mach5 system
The previous 8226230 fix fixes the issue in local ubuntu18.04 but it
seems it sometimes still fail in mach5 ubuntu system.
Added some delay to ensure it passes in mach5 system too. Also,
added debug message to show added log if it fails again in some
other system.
Bug: https://bugs.openjdk.java.net/browse/JDK-8242526
webrev: http://cr.openjdk.java.net/~psadhukhan/8242526/webrev.0/
mach5 job trying several times is linked to JBS is green.
Regards
Prasanta
