Hi, Prasanta Looks like another sequence of regressions =(((
Can you please check implementation of these fixes: 1) http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ffe817b77f6a 2) http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/66c4f0fdd33d 3) http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/b8ad62596d8f All of them calculate the size of the component in this way: "width + i.left + i.right + caretMargin" or "d.width - i.left - i.right - caretMargin" And in the current fix you suggest to change this in one place to "width - i.left - i.right + caretMargin" Could you please provide more details why it is necessary to do in this place only? On 09.07.2020 01:36, Prasanta Sadhukhan wrote:
Hi All, Please review a fix for an issue where a white line artifact is appearing in JOptionPane.showMessageDialog, This issue is a regression of JDK-8098835 where the caretMargin is added to TextPane width in getMaximumSize/getMinimumSize/getVisibleEditorRect The present issue stems from the fact that the visibleEditorRect() actually subtracts the caret margin instead of adding to the text pane width. Proposed fix is to add the caret margin width rather than subtracting, to the actual width. Bug: https://bugs.openjdk.java.net/browse/JDK-8239907 webrev: http://cr.openjdk.java.net/~psadhukhan/8239907/webrev.0/ Regards Prasanta
-- Best regards, Sergey.
