On 23-Jul-20 11:55 AM, Sergey Bylokhov wrote:
On 22.07.2020 22:46, Prasanta Sadhukhan wrote:
Hi Sergey,

Not exactly, that is support of heavyweight popup in PopupFactory class. This is in Tooltipmanager which can utilise PopupFactory Heavyweight enhancement but there's no way to create HW popup through TooltipManager class which as shown in

http://hg.openjdk.java.net/jdk/client/file/f054a3a03050/src/java.desktop/share/classes/javax/swing/ToolTipManager.java#l338]

can create only LW and MW popup, not HW.

The MEDIUM_WEIGHT_POPUP and the LIGHT_WEIGHT_POPUP passed to the setPopupType are just a hints for the
popupFactory, both could be ignored. For example if tooltip will be shown
outside of the owner then the HW popup will be used(even if LW or MW were requested). And to expose the PopupFactory.setPopupType() to the user the fix for JDK-8147521 was implemented,

OK, but I dont think that's right as setPopupType() is not public and not available to the user. Maybe for this bug, we can just make that method public!!!!

Regards
Prasanta
it looks the same thing as the current bug:
https://bugs.openjdk.java.net/browse/CCC-8147521

Regards
Prasanta
On 23-Jul-20 2:22 AM, Sergey Bylokhov wrote:
Hi, Prasanta.

Isn't the current bug a duplicate of
https://bugs.openjdk.java.net/browse/JDK-8147521
?

On 22.07.2020 00:44, Prasanta Sadhukhan wrote:
Hi All,

Please review a fix for an issue whereby Java developer is not able to to force the tooltips to be displayed in a heavyweight popup.

In ToolTipManager#showTipWindow() , even if we do "ToolTipManager.setLightWeightPopupEnabled(false)" we can only force a medium weight popup as can be seen here

[http://hg.openjdk.java.net/jdk/client/file/f054a3a03050/src/java.desktop/share/classes/javax/swing/ToolTipManager.java#l338]

In addition, there is also a field "heavyWeightPopupEnabled" inside the ToolTipManager which is not used.. There should be at least one way to force a heavy weight popup in the ToolTipManager.

Proposed fix is to give an option to developer to force tooltip to be displayed in HW. CSR will be raised after technical review

Bug: https://bugs.openjdk.java.net/browse/JDK-8232927

webrev: http://cr.openjdk.java.net/~psadhukhan/8232927/webrev.0

Regards
Prasanta






Reply via email to