Looks fine.

On 28.07.2020 01:16, Prasanta Sadhukhan wrote:
OK. Removed doneTask() asynchronous method. Modified webrev:

http://cr.openjdk.java.net/~psadhukhan/8146451/webrev.1/

mach5 job link in JBS

Regards
Prasanta
On 28-Jul-20 10:20 AM, Sergey Bylokhov wrote:
Hi, Prasanta.

Since the test was updated and now uses invokeAndWait, then probably we can drop
"doneTask()" and all related things used to wait while invokeLater is completed?

On 19.07.2020 05:13, Prasanta Sadhukhan wrote:
Hi All,

Please review a test-fix for an issue seen to be failing in windows in mach5 
with mismatch in bufferedimage.

It seems the test is run asynchronously in test.run() under 
SwingUtilities.invokeLater which is causing the test to be unstable in mach5.

Also, the actual BufferedImage check inside test.run() is done again 
asynchronously under another invokeLater(). Although it's not invalid, it's 
causing some instability.

Proposed fix is to run the test under invokeAndWait() synchronously.

mach5 job run for several iterations has passed and link is present in JBS.

Bug: https://bugs.openjdk.java.net/browse/JDK-8146451

webrev: http://cr.openjdk.java.net/~psadhukhan/8146451/webrev.0/

Regards
Prasanta




--
Best regards, Sergey.

Reply via email to