Hi Phil,
I actually erred on that. I should have used
bughttps://bugs.openjdk.java.net/browse/JDK-8250811 which I created for
this.
I will like probably 3-5 issues out of umbrella task comprising each
module. I can see we have 100 issues for plaf.basic and 40 odd for
plaf.metal so that will be covered in those module.
SHould I sent this review mail again with the above bugid?
Regards
Prasanta
On 30-Jul-20 10:05 PM, Philip Race wrote:
Let's look at how to logically break it up.
Sergey's first point was that you are here grabbing the bug that lists
all issues
and making it the fix for everything.
I think you should withdraw this, turn it into an umbrella and file
separate issues.
But let's not make too many issues. It is fairly mechanical and I'd
like to err on
fewer rather than too many. There's overhead to many as well.
-phil.
On 7/30/20, 9:01 AM, Prasanta Sadhukhan wrote:
Kevin mentioned even if fx they are breaking it up and tackling these
issue.
Regards
Prasanta
On 30-Jul-20 9:27 PM, Prasanta Sadhukhan wrote:
it will be easier for me to break up in parts if I have to do all of
it.
Regards
Prasanta
On 30-Jul-20 9:26 PM, Joe Darcy wrote:
If you want to make the changes all in one go, I can accommodate
that too.
Thanks,
-Joe
On 7/30/2020 8:34 AM, Prasanta Sadhukhan wrote:
I had talked with Joe and it was decided to break up in parts as
it will be easy for him.
Regards
PRasanta
On 30-Jul-20 9:02 PM, Sergey Bylokhov wrote:
On 30.07.2020 01:24, Prasanta Sadhukhan wrote:
Proposed fix is to create no-arg default constructor for
javax.swing.plaf.multi module (as one part of overalll
java.desktop change)
This change is about "javax.swing.plaf.multi" package in the
java.desktop module, but it refers to the JDK-8250639 which is
about all module.
But I suggest making all changes at once instead of split it to
tenths different fixes, the changes are identical and easy for
review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8250639
webrev: http://cr.openjdk.java.net/~psadhukhan/8250639/webrev.0/
CSR: https://bugs.openjdk.java.net/browse/JDK-8250812
Regards
Prasanta
