Hi Alexey,
Thanks for the review
> On 21-Aug-2020, at 1:04 AM, Alexey Ivanov <alexey.iva...@oracle.com> wrote:
>
> Hi Tejpal,
>
> Looks good overall, however, I have a couple of comments.
>
> I suggest using the <col> elements for setting width of table columns. Add
> the following three lines before <thead> in *properties.html*:
>
> <col style="width: 250px">
> <col>
> <col style="width: 100px”>
After making this change doclint is throwing error about the col attribute.
error: tag not allowed here: <col>
So keeping this same as webrev00.
>
> Then you can drop width specifiers from <th> and <td> in the entire table.
> The code will look much cleaner.
>
> Do so for both tables. It should work in all modern browsers without any
> issues.
>
>
> *componentProperties.html*
>
> *JFileChooser* table
>
> 192 <table border="1" style="padding:2px; border-collapse: separate;
> border-spacing: 2px; text-align: left; width: 100%;">
>
> Dropping "padding:2px;" style makes the table look consistent with other
> tables above: there's no additional padding between table border and its
> cells.
>
> Removing all other style attributes ("border-collapse: separate;
> border-spacing: 2px;") does not change rendering. The table looks exactly as
> the table above which does not have any additional style specifiers.
>
> I guess we should strive for consistent look of all the tables on the page.
> Shall we drop the additional attributes then?
Yeah, I have dropped the style attributes to make the table consistent.
Updated webrev : http://cr.openjdk.java.net/~trebari/swing/8251122/webrev01/
<http://cr.openjdk.java.net/~trebari/swing/8251122/webrev01/>
Also there was one new error in java/awt/doc-files/DesktopProperties.html due
to the fix of 8251124.
So I have removed an empty <p> tag.
Also verified that no accessibility doclint errors were thrown.
> The same comments apply to the following JInternalFrame,
> JInternalFrameTitlePane, JProgressBar…
>
> If required, I'd rather add these style declarations inside <style> element
> to all <table> elements.
>
>
> On 20/08/2020 13:21, Tejpal Rebari wrote:
>> Hi All,
>> Please review the following fix for jdk16.
>>
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8251122
>> Webrev : http://cr.openjdk.java.net/~trebari/swing/8251122/webrev00/
>>
>> Issue : doclint html5 errors in
>> java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html
>> Doclint identified that some of the swing classes were still using
>> attributes which is not supported in html5.
>>
>> Fix : Doclint identified that the html attributes like width, bgcolor ,
>> cellspacing, cellpadding were still in use in swing classes.
>> Used CSS properties for these attributes, like style=“width” for width,
>> background-color for bgcolor etc.
>>
>> Verified that the doclint doesn’t throw any error after the fix.
>>
>> Regards
>> Tejpal
> --
> Regards,
> Alexey
Regards
Tejpal
